NEW Use Bootstrap alerts throughout the CMS #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2018
|
Just checked this out, looks good in general. I’d remove the bottom margin when used as a form field error, and possibly add some space above?
|
kinglozzer
approved these changes
Oct 11, 2018
|
Do you think we should merge this in before 4.3 stabilises, or merge in as an early 4.4 enhancement? |
|
This isn’t a hugely intrusive change, given that the styles are so similar to what we already have, plus it only affects CMS form templates... I’d be comfortable merging this in time for 4.3 |
|
Looks good for |
|
We missed feature freeze cutoff day (19th Oct NZST) so I've switched this to 1 for the next release (SilverStripe 4.4) |
|
Builds restarted |
robbieaverill
force-pushed
the
pulls/4.3/bootstrap-alerts
branch
from
b381610 to
f11cd44
Compare
|
Self merging with @kinglozzer's approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an extension which provides SilverStripe message types to templates as Bootstrap alert types, and implements them in all of the admin templates that use $MessageType
Issue: silverstripe/silverstripe-framework#5674
Requires silverstripe/silverstripe-framework#8377 to merged for Behat to pass